New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BinaryReader Span-based APIs #22851

Closed

4 tasks

stephentoub opened this issue Jul 19, 2017 · 1 comment

Labels

api-approved area-System.IO help wanted tenet-performance

Milestone

Member

stephentoub commented Jul 19, 2017

Separated out of https://github.com/dotnet/corefx/issues/21281 for tracking purposes.

Implement in System.Private.CoreLib in coreclr
Implement in System.Private.CoreLib in corert (if BinaryReader isn't yet in "shared")
Expose from System.IO contract in corefx
Add tests to System.IO tests in corefx

namespace System.IO
{
    public class BinaryReader
    {
        public virtual int Read(Span<byte> destination);
        public virtual int Read(Span<char> destination);
        …
    }
}

Contributor

pjanotti commented Sep 15, 2017

/cc @stephentoub closing per PRs above

pjanotti closed this as completed

msftgits transferred this issue from dotnet/corefx

msftgits added this to the 2.1.0 milestone

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.