Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Commit

Permalink
Reeenable VisualBasic test on ILC. (#22121)
Browse files Browse the repository at this point in the history
The underlying codegen bug has been fixed.

Fixes https://github.com/dotnet/corefx/issues/21682
  • Loading branch information
atsushikan authored and stephentoub committed Jul 12, 2017
1 parent 24f696a commit d841654
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions src/Microsoft.VisualBasic/tests/OperatorsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public static IEnumerable<object[]> AddObject_Idempotent_TestData()
yield return new object[] { (ulong)12, "2", (double)14 };
yield return new object[] { (ulong)13, true, (decimal)12 };
yield return new object[] { (ulong)14, null, (ulong)14 };
yield return new object[] { (ulong)15, ulong.MaxValue, decimal.Parse("18446744073709551630") };

// long + primitives.
yield return new object[] { (long)8, (long)2, (long)10 };
Expand All @@ -121,6 +122,7 @@ public static IEnumerable<object[]> AddObject_Idempotent_TestData()
yield return new object[] { (long)12, "2", (double)14 };
yield return new object[] { (long)13, true, (long)12 };
yield return new object[] { (long)14, null, (long)14 };
yield return new object[] { (long)15, long.MaxValue, decimal.Parse("9223372036854775822") };

// float + primitives
yield return new object[] { (float)9, (float)2, (float)11 };
Expand Down Expand Up @@ -181,14 +183,6 @@ public void AddObject_Convertible_ReturnsExpected(object left, object right, obj
}
}

[Fact]
[ActiveIssue("https://github.com/dotnet/corefx/issues/21682 -- fails when /buildtype:ret passed to ILC", TargetFrameworkMonikers.UapAot)]
public void AddObject_Convertible_ReturnsExpected_64BitOverflow()
{
AddObject_Convertible_ReturnsExpected((ulong)15, ulong.MaxValue, decimal.Parse("18446744073709551630"));
AddObject_Convertible_ReturnsExpected((long)15, long.MaxValue, decimal.Parse("9223372036854775822"));
}

[Fact]
public void AddObject_DateString_ReturnsExpected()
{
Expand Down

0 comments on commit d841654

Please sign in to comment.