Upgrade Linux build to use Unicode 8.0 #5221
Conversation
We have done this upgrade for Windows awhile ago. the change here is to do the same for Linux The fix should take care with the issue https://github.com/dotnet/corefx/issues/7351
|
@ellismg could you please have a look? this is pure data changes and there is no real code change. let me know if you have any question |
|
LGTM |
|
thanks @ellismg |
|
Nice. I'm curious: why do we have two separate implementations of System.Globalisation. It seems that the Windows code is already there In the corefx but uses a different code base in the src folder |
we are planning at some point to consolidates the code between Windows and Linux. we originally used the refactored code in Linux implementation but didn't have chance to consolidate it with Windows implementation. |
|
Why didn't you have the chance? Thanks |
|
@hughbe because it needs some effort and time. for example, we'll need to consolidate the PAL layer. and carefully look at the two implementation and pick the reasonable one without introducing any regression. there is also part o the code need to be more refactored (like TimeZoneInfo)...etc. so this is not a priority item for now to do. |
…oUnicode8 Upgrade Linux build to use Unicode 8.0 Commit migrated from dotnet/coreclr@8eb31f2
We have done this upgrade for Windows awhile ago. the change here is to do the same for Linux
The fix should take care with the issue https://github.com/dotnet/corefx/issues/7351