This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Pre-consolidation mop up fixes #3 #27836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change contains the remaining fixes I made while digging through the PR run in the runtime repo: 1) Some more repo-relative vs. coreclr-relative repo adjustments reflecting the migration process; 2) Make sure that XunitTestBinBase always ends with a directory separator, otherwise my recent fix for Common folder exclusion doesn't work; 3) Opportunistically shorten project names of two native interop test components - as the project name is repeated about 3-4 times in some intermediate paths, it quickly exceeds the standard Windows path length limit. Please note there's no functional change in the test. Thanks Tomas
janvorli
reviewed
Nov 12, 2019
jashook
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains the remaining fixes I made while digging
through the PR run in the runtime repo:
Some more repo-relative vs. coreclr-relative repo adjustments
reflecting the migration process;
Make sure that XunitTestBinBase always ends with a directory
separator, otherwise my recent fix for Common folder exclusion
doesn't work;
Opportunistically shorten project names of two native interop
test components - as the project name is repeated about 3-4 times
in some intermediate paths, it quickly exceeds the standard
Windows path length limit. Please note there's no functional
change in the test.
Thanks
Tomas