This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix some nullable annotations from API Review #24937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/RtFieldInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/XXXOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/MdFieldInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/MethodBuilder.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
jkotas
reviewed
Jun 4, 2019
jkotas
reviewed
Jun 4, 2019
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorBuilder.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Reflection/MethodInfo.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 4, 2019
stephentoub
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Reflection/Emit/Opcode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 4, 2019
stephentoub
reviewed
Jun 4, 2019
stephentoub
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/MethodBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/MethodBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 4, 2019
safern
force-pushed
the
FixNullableAnnotationsApiReview
branch
from
June 4, 2019 06:42
d37edc4
to
6fa8467
Compare
safern
force-pushed
the
FixNullableAnnotationsApiReview
branch
from
June 4, 2019 06:45
6fa8467
to
9d98b48
Compare
I just finished addressing PR Feedback. Would you guys mind taking another look? |
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/shared/System/Resources/ManifestBasedResourceGroveler.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/MethodBuilder.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 4, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/SymbolMethod.cs
Outdated
Show resolved
Hide resolved
safern
force-pushed
the
FixNullableAnnotationsApiReview
branch
from
June 4, 2019 22:27
560de78
to
b9e65b9
Compare
jkotas
approved these changes
Jun 4, 2019
I put up a PR to fix the tests in corefx: dotnet/corefx#38269 Will push a commit to disable those tests here in coreclr. |
@safern You did not click "Squash and merge", please try to do that if this is not intentional which from the commit descriptions does not seem like it. |
Damn it. Sorry again. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tionsApiReview Fix some nullable annotations from API Review Commit migrated from dotnet/coreclr@a64cb0a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the annotations that we found out were wrong during API Reviews and also enabled CS8609 (covariant overriden return type) globally and disabled in places where we intentionally are overriding with a different return type.
Also, fixed some annotations in MethodInfo based on an offline conversation with @jkotas
Here are the notes from the review: https://github.com/dotnet/apireviews/blob/b2a7fcaf18d92267cf41258205e55ad0dd1b2a41/2019/System.Runtime-Nullable/README.md