Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update added types and methoddefs on ApplyMetadata #22617

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Update added types and methoddefs on ApplyMetadata #22617

merged 4 commits into from
Feb 26, 2019

Conversation

davmason
Copy link
Member

This change is necessary to allow metadata rewriting at ReJIT time instead of at module load time

@davmason davmason self-assigned this Feb 15, 2019
noahfalk
noahfalk reviewed Feb 15, 2019
View reviewed changes
src/vm/proftoeeinterfaceimpl.cpp Show resolved Hide resolved
src/vm/ceeload.h Show resolved Hide resolved
src/vm/ceeload.cpp Show resolved Hide resolved
@davmason davmason mentioned this pull request Feb 16, 2019
Merged
@davmason
Copy link
Member Author

@dotnet-bot test coreclr-ci (Test Pri0 Windows_NT x86 checked)

@davmason
Copy link
Member Author

@noahfalk can you take a look at the changes I just added? I added a fix for #18536 (a port of your fix from noahfalk@5f37ab7 plus making it work for exported types as well)

@davmason
Copy link
Member Author

@noahfalk I need to take a second look at this. I don't think I looked at LazyPopulateCaseSensitiveHashTables close enough. I don't think it does what I want and isn't safe to call repeatedly.

noahfalk
noahfalk approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one other comment I missed before

src/vm/ceeload.h Show resolved Hide resolved
@davmason
Copy link
Member Author

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Ubuntu x64 Formatting

@davmason davmason closed this Feb 25, 2019
@davmason davmason reopened this Feb 25, 2019
@davmason
Copy link
Member Author

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked crossgen_comparison Build and Test
@dotnet-bot test Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Release crossgen_comparison Build and Test
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests

@davmason
Copy link
Member Author

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

@davmason
Copy link
Member Author

I don’t know what’s up with the CI, but all these legs were passing before I reset them. I’m going to merge now.

@davmason davmason merged commit ee755e3 into dotnet:master Feb 26, 2019
@davmason davmason deleted the metadata branch February 26, 2019 16:56
jkotas added a commit to jkotas/coreclr that referenced this pull request Feb 28, 2019
@jkotas
Revert "Update added types and methoddefs on ApplyMetadata (dotnet#22617
ff82e23 
)"

This reverts commit ee755e3.
@jkotas jkotas mentioned this pull request Feb 28, 2019
Merged
jkotas added a commit that referenced this pull request Feb 28, 2019
@jkotas
Revert "Update added types and methoddefs on ApplyMetadata (#22617)" (#…
f9c10f9 
…22923)

This reverts commit ee755e3.
davmason added a commit that referenced this pull request Mar 19, 2019
@davmason
Reintroduce PR #22617 (Update added types and methoddefs on ApplyMeta…
5aacb1d 
…data) (#23202)

* Add ApplyMetadata changes back

This reverts commit f9c10f9.

* Fix race condition in loading available class hash for R2R with old R2R images or profiler modified R2R images
@jkotas jkotas mentioned this pull request Jan 31, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@davmason
Update added types and methoddefs on ApplyMetadata (dotnet/coreclr#22617
d4561ed 
)

Commit migrated from dotnet/coreclr@ee755e3
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@jkotas
Revert "Update added types and methoddefs on ApplyMetadata (dotnet/co…
1f16507 
…reclr#22617)" (dotnet/coreclr#22923)

This reverts commit dotnet/coreclr@ee755e3.

Commit migrated from dotnet/coreclr@f9c10f9
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@davmason
Reintroduce PR dotnet/coreclr#22617 (Update added types and methoddef…
95a3d10 
…s on ApplyMetadata) (dotnet/coreclr#23202)

* Add ApplyMetadata changes back

This reverts commit dotnet/coreclr@f9c10f9.

* Fix race condition in loading available class hash for R2R with old R2R images or profiler modified R2R images


Commit migrated from dotnet/coreclr@5aacb1d
@davmason davmason mentioned this pull request Feb 16, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@davmason davmason

Labels
area-Diagnostics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davmason @noahfalk