Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Span Fill, Clear, and CopyTo method implementations #7305

Closed
ahsonkhan opened this issue Jan 27, 2017 · 4 comments · Fixed by dotnet/coreclr#9999
Closed

Optimize Span Fill, Clear, and CopyTo method implementations #7305

ahsonkhan opened this issue Jan 27, 2017 · 4 comments · Fixed by dotnet/coreclr#9999
Assignees
@ahsonkhan
Labels
area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Milestone
2.0.0

Comments

@ahsonkhan
Copy link
Member

Currently the following Span methods contain trivial implementations and they need to be optimized.

  • Fill
  • Clear
  • CopyTo
@gkhanna79
Copy link
Member

@kouvel Is this something you will be working upon? If so, can you please assign to your self or reassign as appropriate?

@kouvel
Copy link
Member

kouvel commented Jan 29, 2017

@ahsonkhan, is this something you will be working on later?

@ahsonkhan
Copy link
Member Author

@kouvel, I wasn't planning on working on this in the near future.

@jkotas
Copy link
Member

jkotas commented Jan 30, 2017

We will want to add some runtime helpers to make these efficient. It would be nice to match the names and signatures of the similar helpers in CoreRT to ease sharing of the implementation:

e.g. RhBulkMoveWithWriteBarrier https://github.com/dotnet/corert/blob/d84f5310c80708584bb908615a331b5520a28d63/src/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs#L531

kouvel referenced this issue in kouvel/coreclr Mar 7, 2017
@kouvel
Improve span copy of pointers and structs containing pointers
6a66f68 
Fixes #9161
kouvel referenced this issue in kouvel/coreclr Mar 7, 2017
@kouvel
Improve span copy of pointers and structs containing pointers
b296a68 
Fixes #9161

PR dotnet#9786 fixes perf of span copy of types that don't contain references
kouvel referenced this issue in kouvel/coreclr Mar 8, 2017
@kouvel
Improve span copy of pointers and structs containing pointers
75cc69f 
Fixes #9161

PR dotnet#9786 fixes perf of span copy of types that don't contain references
kouvel referenced this issue in dotnet/coreclr Mar 9, 2017
@kouvel
Improve span copy of pointers and structs containing pointers (#9999)
a6a7bde 
Improve span copy of pointers and structs containing pointers

Fixes #9161

PR #9786 fixes perf of span copy of types that don't contain references
jorive referenced this issue in guhuro/coreclr May 4, 2017
@kouvel @jorive
Improve span copy of pointers and structs containing pointers (dotnet…
27daa14 
…#9999)

Improve span copy of pointers and structs containing pointers

Fixes #9161

PR dotnet#9786 fixes perf of span copy of types that don't contain references
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ahsonkhan ahsonkhan

Labels
area-System.Runtime help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Improve span copy of pointers and structs containing pointers kouvel/coreclr
5 participants
@ahsonkhan @jkotas @msftgits @gkhanna79 @kouvel