Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span: VM side of GC reporting for Span<T> - investigate struct passing in regs on Unix #7264

Closed
kouvel opened this issue Jan 21, 2017 · 1 comment
Closed

Span: VM side of GC reporting for Span<T> - investigate struct passing in regs on Unix #7264

kouvel opened this issue Jan 21, 2017 · 1 comment
Assignees
@kouvel
Labels
area-System.Runtime
Milestone
2.0.0

Comments

@kouvel
Copy link
Member

kouvel commented Jan 21, 2017

Investigate if there is an issue with structs being passed in registers on Unix:

  • Passing a span as an argument in registers (potentially fix ReportPointersFromStructInRegisters to cover ByRefLike types)
  • Returning a span in registers during GC suspension
@kouvel kouvel self-assigned this Jan 21, 2017
kouvel referenced this issue in kouvel/coreclr Feb 1, 2017
@kouvel
Fix GC reporting for Span<T> passed in registers on Unix
5db1c79 
Part of fix for #9033

Test coverage is already there in CoreFX's span tests.
jkotas referenced this issue in dotnet/coreclr Feb 1, 2017
@kouvel @jkotas
Fix GC reporting for Span<T> passed in registers on Unix (#9247)
7ced6b5 
Part of fix for #9033

Test coverage is already there in CoreFX's span tests.
@kouvel
Copy link
Member Author

kouvel commented Feb 10, 2017

Looks like returning in registers during GC suspension is not an issue

@kouvel kouvel closed this as completed Feb 10, 2017
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kouvel kouvel

Labels
area-System.Runtime
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@msftgits @kouvel