-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with VS 2017 only doesn't work #7859
Comments
Can you try "clean -all" from the root, then try again? |
@danmosemsft Iam getting the exact same error when I try to Build. I also tried |
does this file exist? \Tools/net46/Microsoft.DotNet.Build.Tasks.dll |
I am without computer access. It happened even after a Windows clean installation (Creators update). |
@danmosemsft Yes,The File exists but I get the same error |
@danmosemsft I also tried building the repo on an Azure VM but It's showing the same error.I think this issue needs some attention. |
I'm having this issue also on a brand new clone. From VS2017 developer command prompt:
Whereas with the VS2015 developer command prompt I get:
https://github.com/dotnet/coreclr/issues/10181 looks related. |
Here is the log from the brand new Windows install and pre requisites:
|
@gkhanna79, should we prioritize this issue? |
@tannergooding Can you PTAL? |
In both cases, the only difference I see in the output given and the output I produce is that my build is additionally passing in: However, the error logs they have both have the following path: My Output:
|
@tannergooding have you installed VS2015 in that computer? |
I have the exact same problem running the build from the VS2017 prompt on a brand new Windows install without VS2015 that I did on a machine with VS2015. |
@fujiy, I valided on machines with the following configurations:
|
@tannergooding This is frustrating. I'm loathe to install VS2015 on my new builds of Windows, so I have to remote to the machine that has it in order to build coreclr. What can we do to facilitate a fix to allow building from the VS2017 prompt? |
@tannergooding Didn't you confirm that repo built clean from within VS 2017 prompt? |
@jnm2, that's the thing. I can successfully build on VS2017 standalone (Community, Professional, or Enterprise) without any issues (both from clean machines and from existing machines with other VS instances). So I am unsure what is blocking your machine from doing the same. The only difference I've seen in the logs is that your path is somehow resolving to have This is the command that is failing for you: and given the failure, my best guess would be to just "correct" the path for the /l:BinClashLogger arg and see if that resolves the issue (so run Outside of that, I don't think I'll be able to get much further without diagnostic MSBuild logs. |
@tannergooding Running the failing command gives the original error. Running the command you corrected gives:
Guess I'll post a diagnostic log next. |
@jnm2, are you running commands from the repository root (looks like I'm actually wondering if this is a similar issue to dotnet/corefx#18700, commands would fail if the repository root was not your working directory. |
@tannergooding I have been, but for that command I cd'd to \Tools. I'll try from the root. Ah, the corrected command succeeded from the root. |
@tannergooding Both commands succeed when the working directory is the repo root. However, I have never run |
Awesome. @gkhanna79, It looks like there are two parts to a fix here:
|
Now I can build CoreFX. I'm not sure why, since I always built from the repository directory. Is VS Developer CMD forcing a different working directory? |
@fujiy I think because dotnet/corefx#18700 was merged four days ago? |
Yes, as @tannergooding said, we need a similar fix for CoreClr. What doesn't make sense yet is that I was building from repository directory, It seems that VS 2017 Developer CMD is changing the working directory |
I'm doing some tests and I will try to send a fix |
I followed the instructions mentioned here: https://github.com/dotnet/coreclr/blob/master/Documentation/building/windows-instructions.md for Visual Studio 2017.
I don't have VS 2015.
When calling build from Developer Command Prompt for VS 2017 I receive this error:
The text was updated successfully, but these errors were encountered: