This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Revert "[master] Update dependencies from dotnet/corefx (#8266)" #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c8a9346.
|
Filed https://github.com/dotnet/core-setup/issues/8297 to track making the tests not do that, with some more description. |
|
FYI @wtgodbe @mmitche, it's possible for Maestro++ updates to sneak through in Core-Setup and break builds if the public CI build number matches a successful official build's number. Something to be aware of until dotnet/arcade#3938 is deployed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #8266.
That PR removed
TEST_RESTORE_SOURCES_INSERTION_LINE, which normally causes test restore to fail. It looks like it didn't fail in this case because an internal build published packages with the same versions due to a coincidental build number match. The green build allowed the PR to merge, but now it's breaking builds where this coincidence isn't occurring.