Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget package create/unpack needs to respect unix file permissions [2.0.0] #8178

Closed
tmds opened this issue Apr 27, 2017 · 2 comments
Closed

Comments

@tmds
Copy link
Member

tmds commented Apr 27, 2017

At 1.x, files created by .NET Core had the execute bit set.
This means that NuGet packages containing executables would work, independent of the bit being set in the zip file.

For 2.x, the execute permission is no longer set. (dotnet/coreclr#7995)
This means NuGet packages need to be created and unpacked with correct permissions.
This is not the case currently.

Most packages contain only dlls and so files, they seem to work fine without the x-bit.
Packages containing executables&scripts are affected.

Once the packing is made permission aware, packages that rely on the 1.x behavior to set the x-bit will need to be repacked for 2.0.

@dasMulli
Copy link
Contributor

Dupe of NuGet/Home#4424?

@tmds
Copy link
Member Author

tmds commented Apr 27, 2017

@dasMulli indeed, also a dup. Added a comment there.

@tmds tmds closed this as completed Apr 27, 2017
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants