This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Include dumpasync command when evaluating core dumps #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/coreclr#18160 and dotnet/coreclr#18213 added a new `dumpasync` command to sos that will dump out data on async methods currently in use. Including this in the core dump analysis has similar value to dumping out all call stacks, in that it'll give us more details into what was going on in the process.
|
fyi @ahsonkhan who has taken over fixing this experience. |
danmoseley
approved these changes
Jun 1, 2018
|
I assume your SOS changes arrive for free in CoreFX with CoreCLR (at least right now)? |
Yeah. It's not there yet, but it should be in the next coreclr update consumed into corefx. |
Anipik
approved these changes
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/coreclr#18160 and dotnet/coreclr#18213 added a new
dumpasynccommand to sos that will dump out data on async methods currently in use. Including this in the core dump analysis has similar value to dumping out all call stacks, in that it'll give us more details into what was going on in the process.cc: @danmosemsft, @Anipik