From ad738e4dc21c43bd2c15d11d7224979d9a9a39e6 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Tue, 7 Mar 2023 10:49:35 -0600 Subject: [PATCH 1/2] Skip HelixPlatform_QuickListenerIsSupported on win-arm64 The current version of msquic doesn't have win-arm64 binaries. See https://github.com/dotnet/msquic/pull/131. Issues tracking re-enabling the test is https://github.com/dotnet/aspnetcore/issues/47065 --- src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs index a9f011f4ffe2..d6f69f236db1 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs @@ -27,7 +27,7 @@ public class WebHostTests : LoggedTest [SkipNonHelix] [SkipOnAlpine("https://github.com/dotnet/aspnetcore/issues/46537")] [SkipOnMariner("https://github.com/dotnet/aspnetcore/issues/46537")] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/46616", Queues = "Debian.12.Arm64.Open;")] + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/46616;https://github.com/dotnet/aspnetcore/issues/47065", Queues = "Debian.12.Arm64.Open;Windows.Amd64.Server2022.Open")] [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "HTTP/3 isn't supported on MacOS.")] [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win11_21H2)] public void HelixPlatform_QuickListenerIsSupported() From 25ec5a806a2428bb3c0e7c0e492cd32fe419c1f7 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Tue, 7 Mar 2023 11:18:31 -0600 Subject: [PATCH 2/2] PR feedback --- src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs index d6f69f236db1..0eef47c9819f 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs @@ -30,7 +30,7 @@ public class WebHostTests : LoggedTest [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/46616;https://github.com/dotnet/aspnetcore/issues/47065", Queues = "Debian.12.Arm64.Open;Windows.Amd64.Server2022.Open")] [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "HTTP/3 isn't supported on MacOS.")] [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win11_21H2)] - public void HelixPlatform_QuickListenerIsSupported() + public void HelixPlatform_QuicListenerIsSupported() { Assert.True(QuicListener.IsSupported, "QuicListener.IsSupported should be true."); Assert.True(new MsQuicSupportedAttribute().IsMet, "MsQuicSupported.IsMet should be true.");