Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inline Vector128.Create for constants #33969

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Use inline Vector128.Create for constants #33969

merged 2 commits into from
Jul 2, 2021

Conversation

gfoidl
Copy link
Member

@gfoidl gfoidl commented Jun 30, 2021

Cf. dotnet/runtime#44115
Case 1.1 is used, that produces best machine code (I verifyed it).

@gfoidl gfoidl requested a review from Pilchie as a code owner June 30, 2021 17:37
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 30, 2021
@Pilchie Pilchie requested review from davidfowl and Tratcher and removed request for Pilchie July 1, 2021 16:05
@Tratcher Tratcher requested a review from halter73 July 1, 2021 16:17
@Tratcher Tratcher merged commit 2337bf5 into dotnet:main Jul 2, 2021
@ghost ghost added this to the 6.0-preview7 milestone Jul 2, 2021
@Tratcher
Copy link
Member

Tratcher commented Jul 2, 2021

Thanks

@gfoidl gfoidl deleted the vector-constants branch July 5, 2021 08:48
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

@halter73 halter73 Awaiting requested review from halter73

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@gfoidl @Tratcher @Pilchie @amcasey