Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow aspnet-browser-refresh.js to be inserted multiple times #35334

Closed
pranavkm opened this issue Aug 13, 2021 · 1 comment
Closed

Allow aspnet-browser-refresh.js to be inserted multiple times #35334

pranavkm opened this issue Aug 13, 2021 · 1 comment
Assignees
@SteveSandersonMS
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Milestone
6.0.0

Comments

@pranavkm
Copy link
Contributor

As part of #28293 (comment), we recommend users to manually add the browser script to their applications. However the script isn't robust against multiple copies of it being added and will do thing like set up multiple WS connections. We could add some smarts to it to prevent double initialization.
@pranavkm pranavkm added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Aug 13, 2021
@pranavkm pranavkm added this to the 6.0.0 milestone Aug 19, 2021
@mkArtakMSFT mkArtakMSFT added the feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) label Sep 21, 2021
@ghost ghost added the Working label Sep 27, 2021
@SteveSandersonMS SteveSandersonMS mentioned this issue Sep 27, 2021
Merged
10 tasks
@SteveSandersonMS
Copy link
Member

Done in dotnet/sdk#21429

@ghost ghost added Done This issue has been fixed and removed Working labels Oct 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@pranavkm @SteveSandersonMS @mkArtakMSFT