Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume Optimization Training Data for CrossGen2 in build #31040

Closed
2 tasks
Pilchie opened this issue Mar 18, 2021 · 5 comments
Closed
2 tasks

Consume Optimization Training Data for CrossGen2 in build #31040

Pilchie opened this issue Mar 18, 2021 · 5 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-perf Performance infrastructure issues
Milestone

Comments

@Pilchie
Copy link
Member

Pilchie commented Mar 18, 2021

We'll need to:

  • update our build to use crossgen2
  • update our build to consume optimization training data (in the form of NuGet packages) that the perf lab will be producing.
@Pilchie Pilchie added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-perf Performance infrastructure issues labels Mar 18, 2021
@Pilchie
Copy link
Member Author

Pilchie commented Mar 18, 2021

See dotnet/runtime#49793 for an example of some of this in dotnet/runtime

@davidwrighton
Copy link
Member

The expectation is that the aspnet repo will be able to use the same packages as are used by the runtime repo, or that the runtime repo will produce a new set of packages for downstream consumption. Regardless, the priority is to enable crossgen2, and then enabling the pgo data should be relatively simple.

@Pilchie
Copy link
Member Author

Pilchie commented Mar 22, 2021

Would like to get this done no later than Preview 5, but not putting in that milestone in case we pick it up earlier.

Also tagging @dotnet/aspnet-build

@AndyAyersMS
Copy link
Member

Is this done?

I see the crossgen2 update happened, and that it will consume PGO data if that data's available, but I can't tell if the data actually is available.

@dougbu
Copy link
Member

dougbu commented Jun 3, 2021

Is this done?

Yes, @AndyAyersMS, complete with 46b56aa. Thanks for the reminder.

Thanks again to @davidwrighton for his #31778. My final changes (after lots of testing) wasn't much different than @davidwrighton's work.

@dougbu dougbu closed this as completed Jun 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-perf Performance infrastructure issues
Projects
None yet
Development

No branches or pull requests

4 participants