From f7f4212301035b759aa6cb124b665fb604d69ddd Mon Sep 17 00:00:00 2001 From: Sam Spencer <54915162+samsp-msft@users.noreply.github.com> Date: Tue, 27 Feb 2024 12:23:48 -0800 Subject: [PATCH 1/4] Improve intellisense for AddConnectionString Unclear what the name will be used for, and where its located. --- .../Extensions/ParameterResourceBuilderExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs index d56629ee40..cadb868d02 100644 --- a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs +++ b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs @@ -67,7 +67,7 @@ private static void WriteParameterResourceToManifest(ManifestPublishingContext c /// Adds a parameter to the distributed application but wrapped in a resource with a connection string for use with /// /// Distributed application builder - /// Name of parameter resource + /// Name of parameter resource, maps to the key under "ConnectionStrings" section in appsettings.json or user secrets /// Environment variable name to set when WithReference is used. /// Resource builder for the parameter. /// From c0caf4bbb2f1faf62d8e8eaf67a2f60cb94be054 Mon Sep 17 00:00:00 2001 From: Sam Spencer <54915162+samsp-msft@users.noreply.github.com> Date: Tue, 27 Feb 2024 15:59:28 -0800 Subject: [PATCH 2/4] Update src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs Co-authored-by: Eric Erhardt --- .../Extensions/ParameterResourceBuilderExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs index cadb868d02..51c7039343 100644 --- a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs +++ b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs @@ -67,7 +67,7 @@ private static void WriteParameterResourceToManifest(ManifestPublishingContext c /// Adds a parameter to the distributed application but wrapped in a resource with a connection string for use with /// /// Distributed application builder - /// Name of parameter resource, maps to the key under "ConnectionStrings" section in appsettings.json or user secrets + /// Name of parameter resource. Maps to the key under the "ConnectionStrings" configuration section, for example in appsettings.json or user secrets /// Environment variable name to set when WithReference is used. /// Resource builder for the parameter. /// From 64715834d82cfd0e580ed059a5cbf6c200964dd3 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Tue, 27 Feb 2024 19:40:33 -0800 Subject: [PATCH 3/4] Update ParameterResourceBuilderExtensions.cs --- .../Extensions/ParameterResourceBuilderExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs index 51c7039343..c47a1bc1ce 100644 --- a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs +++ b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs @@ -67,7 +67,7 @@ private static void WriteParameterResourceToManifest(ManifestPublishingContext c /// Adds a parameter to the distributed application but wrapped in a resource with a connection string for use with /// /// Distributed application builder - /// Name of parameter resource. Maps to the key under the "ConnectionStrings" configuration section, for example in appsettings.json or user secrets + /// Name of parameter resource. The value of the connection string comes from the "ConnectionStrings:{resourcename}" configuration section, for example in appsettings.json or user secrets /// Environment variable name to set when WithReference is used. /// Resource builder for the parameter. /// From e1ba93f6710961deb308cb4f2fdb9092e23bbece Mon Sep 17 00:00:00 2001 From: David Fowler Date: Wed, 28 Feb 2024 12:25:05 -0800 Subject: [PATCH 4/4] Update src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs --- .../Extensions/ParameterResourceBuilderExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs index c47a1bc1ce..d93f15d261 100644 --- a/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs +++ b/src/Aspire.Hosting/Extensions/ParameterResourceBuilderExtensions.cs @@ -67,7 +67,7 @@ private static void WriteParameterResourceToManifest(ManifestPublishingContext c /// Adds a parameter to the distributed application but wrapped in a resource with a connection string for use with /// /// Distributed application builder - /// Name of parameter resource. The value of the connection string comes from the "ConnectionStrings:{resourcename}" configuration section, for example in appsettings.json or user secrets + /// Name of parameter resource. The value of the connection string is read from the "ConnectionStrings:{resourcename}" configuration section, for example in appsettings.json or user secrets /// Environment variable name to set when WithReference is used. /// Resource builder for the parameter. ///