Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo dependency on daily builds of Microsoft.Extensions.Http.Resilience #942

Closed
eerhardt opened this issue Nov 17, 2023 · 4 comments · Fixed by #1054
Closed

Undo dependency on daily builds of Microsoft.Extensions.Http.Resilience #942

eerhardt opened this issue Nov 17, 2023 · 4 comments · Fixed by #1054
Assignees
@joperezr
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Milestone
preview 2 (Dec)

Comments

@eerhardt
Copy link
Member 

          > > This error does touch on the servicing conversation though. Are we guaranteed that Microsoft.Extensions.Http.Resilience version 8.1.0 will ship on nuget.org before we ship our preview2? cc @joperezr

The current plan is to ship 8.1.0 Jan 9th.

Sounds like we will need to back out updating this reference then.

Originally posted by @eerhardt in #939 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 17, 2023
@eerhardt eerhardt added area-engineering-systems infrastructure helix infra engineering repo stuff and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 17, 2023
@eerhardt eerhardt mentioned this issue Nov 17, 2023
Merged
@joperezr
Copy link
Member

Correct, I'll take care of this for preview 2.

@joperezr joperezr self-assigned this Nov 27, 2023
@joperezr joperezr added this to the preview 2 (Dec) milestone Nov 27, 2023
@joperezr joperezr mentioned this issue Nov 27, 2023
Merged
@joperezr
Copy link
Member

This is now done.

@eerhardt
Copy link
Member Author

This doesn't appear to be done - we are still depending on 8.1.-preview:

aspire/eng/Versions.props

Line 27 in c2b1b8f

<MicrosoftExtensionsHttpResiliencePackageVersion>8.1.0-preview.23572.3</MicrosoftExtensionsHttpResiliencePackageVersion>

@eerhardt eerhardt reopened this Nov 27, 2023
@joperezr
Copy link
Member

I turned off the subscription, so we won't get any future update PRs which I thought was what this was tracking. I was already working on reverting the updates to 8.1 versions anyway, but I'm fine to not closing this until that is done.

@joperezr joperezr mentioned this issue Nov 27, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joperezr joperezr

Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Milestone
preview 2 (Dec)
2 participants
@eerhardt @joperezr