Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add docs for GetEnvironmentVariableValuesAsync #4551

Closed
Alirexaa opened this issue Jun 17, 2024 · 1 comment
Closed

Docs: Add docs for GetEnvironmentVariableValuesAsync #4551

Alirexaa opened this issue Jun 17, 2024 · 1 comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Comments

@Alirexaa
Copy link
Contributor

we add GetEnvironmentVariableValuesAsync method at PR #4530

add some <remarks> which cover where this method is useful and considerations around the sync nature. As well as one or two <example> sections that cover its usage.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jun 17, 2024
@mitchdenny
Copy link
Member

Closing this since we wouldn't defer adding XML doc comments before merging the PR. XML doc comments should always go in with the PR that adds the API.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchdenny @Alirexaa