Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddBicepTemplateString should output a resourceName.module.bicep instead of a random path. #3273

Closed
mitchdenny opened this issue Mar 29, 2024 · 0 comments · Fixed by #3331
Closed
Assignees
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication azure Issues associated specifically with scenarios tied to using Azure

Comments

@mitchdenny
Copy link
Member

mitchdenny commented Mar 29, 2024

Currently when we AddBicepTemplateString(...) the manifest contains a relative path to the temp directory and a random file. The filename should be predictable and published alongside the manifest file with the name <resourceName>.module.bicep to be consistent with the other resources.

@davidfowl already had a fix on another branch:

path = TempDirectory is null
? Path.Combine(directory ?? Directory.CreateTempSubdirectory("aspire").FullName, $"{Name.ToLowerInvariant()}.bicep")
: Path.Combine(TempDirectory, $"{Name.ToLowerInvariant()}.bicep");

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 29, 2024
@mitchdenny mitchdenny added this to the preview 6 (Apr) milestone Mar 29, 2024
@mitchdenny mitchdenny self-assigned this Mar 29, 2024
@davidfowl davidfowl added the azure Issues associated specifically with scenarios tied to using Azure label Mar 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication azure Issues associated specifically with scenarios tied to using Azure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants