Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration tests for the rest of the Components #1566

Closed
4 tasks done
eerhardt opened this issue Jan 5, 2024 · 5 comments
Closed
4 tasks done

Create integration tests for the rest of the Components #1566

eerhardt opened this issue Jan 5, 2024 · 5 comments
Assignees
Labels
area-integrations Issues pertaining to Aspire Integrations packages testing ☑️

Comments

@eerhardt
Copy link
Member

eerhardt commented Jan 5, 2024

We are missing the EntityFramework components in our functional integration tests added in #1217. We should add them, plus any other missing components that would be valuable.

TODO:

  • efsqlserver
  • efcosmos
  • eforacle
  • efpostgres
@eerhardt eerhardt added the area-integrations Issues pertaining to Aspire Integrations packages label Jan 5, 2024
@eerhardt eerhardt added this to the preview 4 (Mar) milestone Jan 22, 2024
@radical
Copy link
Member

radical commented Feb 12, 2024

Is this referring to:

[InlineData("cosmos")]
[InlineData("mongodb")]
[InlineData("mysql")]
[InlineData("pomelo")]
[InlineData("oracledatabase")]
[InlineData("postgres")]
[InlineData("rabbitmq")]
[InlineData("redis")]
[InlineData("sqlserver")]
public async Task VerifyComponentWorks(string component)
{
var response = await _integrationServicesFixture.IntegrationServiceA.HttpGetAsync("http", $"/{component}/verify");
var responseContent = await response.Content.ReadAsStringAsync();
Assert.True(response.IsSuccessStatusCode, responseContent);
}

So, essentially connect, and try some basic operation?

@eerhardt
Copy link
Member Author

Correct. There are components that aren't covered in those tests - like the EF postgres and sql server components.

@joperezr
Copy link
Member

@eerhardt is this issue stale? Are we still missing some test coverage here? If so, is 8.1 the right milestone? I don't think that Ankit is currently looking into this.

@eerhardt
Copy link
Member Author

is this issue stale? Are we still missing some test coverage here?

I'm not sure what you mean by "stale", but this issue is still relevant. We don't have these integration tests yet. So yes we are missing some test coverage here.

If so, is 8.1 the right milestone?

Yes, I believe so. We want better test coverage in 8.1.

@radical
Copy link
Member

radical commented Jul 3, 2024

Last ones completed by #4758 .

@radical radical closed this as completed Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages testing ☑️
Projects
None yet
Development

No branches or pull requests

4 participants