-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need tests for GenerateAzureDevOpsBuildManifest #6330
Comments
@jonfortescue https://github.com/dotnet/core-eng/issues/9658 should be covered too. Folding that into this. |
@jonfortescue What is the status of this? Trying to figure out where I can help out on testing. |
@chcosta ETA for this is EOD next wednesday. |
I think this can be tested by completely removing it. We don't use the manifest generated by this: #6528 We do need tests for the manifest generation in PushToAzureDevOpsArtifacts though https://github.com/dotnet/arcade/pull/6528/files#diff-2c204b59d01e73c04c5834f945685c3f74bbe862e33de4b58cd2ebc47f200cd1R150 |
@mmitche yeah, I had mentioned completely removing it as a possibility and I think that is probably the best path forward. I wasn't sure if I was missing something, but if we can delete code that we're just not using that would be A++ |
Removed code. Will backport to release/5.0 after it makes a round through the normal master, #6529 |
This file was created for the Post-Build Signing project, so it should be tested in it's entirety in relation to that project.
Related PRs:
Code that needs unit testing:
The text was updated successfully, but these errors were encountered: