Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need tests for GenerateAzureDevOpsBuildManifest #6330

Closed
missymessa opened this issue Oct 6, 2020 · 7 comments
Closed

Need tests for GenerateAzureDevOpsBuildManifest #6330

missymessa opened this issue Oct 6, 2020 · 7 comments
Assignees

Comments

@missymessa
Copy link
Member

This file was created for the Post-Build Signing project, so it should be tested in it's entirety in relation to that project.

Related PRs:

Code that needs unit testing:

@mmitche
Copy link
Member

mmitche commented Nov 3, 2020

@jonfortescue https://github.com/dotnet/core-eng/issues/9658 should be covered too. Folding that into this.

@mmitche
Copy link
Member

mmitche commented Nov 3, 2020

@jonfortescue What is the status of this? Trying to figure out where I can help out on testing.

@mmitche mmitche assigned mmitche and unassigned jonfortescue Nov 4, 2020
@mmitche
Copy link
Member

mmitche commented Nov 5, 2020

@chcosta ETA for this is EOD next wednesday.

@mmitche
Copy link
Member

mmitche commented Nov 5, 2020

I think this can be tested by completely removing it. We don't use the manifest generated by this: #6528

We do need tests for the manifest generation in PushToAzureDevOpsArtifacts though https://github.com/dotnet/arcade/pull/6528/files#diff-2c204b59d01e73c04c5834f945685c3f74bbe862e33de4b58cd2ebc47f200cd1R150

@mmitche
Copy link
Member

mmitche commented Nov 5, 2020

#6528

@jonfortescue
Copy link
Member

@mmitche yeah, I had mentioned completely removing it as a possibility and I think that is probably the best path forward. I wasn't sure if I was missing something, but if we can delete code that we're just not using that would be A++

@mmitche
Copy link
Member

mmitche commented Nov 5, 2020

Removed code. Will backport to release/5.0 after it makes a round through the normal master, #6529

@mmitche mmitche closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants