Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maestro should flow missing feeds in NuGet.Config #3944

Closed
JohnTortugo opened this issue Sep 13, 2019 · 2 comments
Closed

Maestro should flow missing feeds in NuGet.Config #3944

JohnTortugo opened this issue Sep 13, 2019 · 2 comments

Comments

@JohnTortugo
Copy link
Contributor

For instance, if the target branch of a subscription doesn't have the static internal feed and the target branch is internal, then Maestro should add the static internal feed to the NuGet.Config file.

/cc @riarenas @mmitche

@riarenas
Copy link
Member

Yeah, right now we only flow the stable feeds that are created dynamically. Seems like a good improvement to always flow any feeds that are present in the asset locations for the dependency we need to update. Requires some changes to how we generate the key for the nuget feed. Should go along with #3938 to avoid merge conflicts

@riarenas
Copy link
Member

We think this could become more harmful than useful, and should just focus on keep flowing and cleaning up the stable feeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants