Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maestro++ / Darc] Dependency update PRs that flow feeds to nuget.config remove comments #3938

Closed
riarenas opened this issue Sep 13, 2019 · 6 comments · Fixed by dotnet/arcade-services#640
Closed

[Maestro++ / Darc] Dependency update PRs that flow feeds to nuget.config remove comments #3938

riarenas opened this issue Sep 13, 2019 · 6 comments · Fixed by dotnet/arcade-services#640
Assignees
@JohnTortugo

Comments

@riarenas
Copy link
Member

We currently only recreate the package sources inside the nuget.config when a dependency update flows new feeds. We should also respect comments in the file
@mmitche mmitche self-assigned this Sep 13, 2019
@mmitche
Copy link
Member

mmitche commented Sep 13, 2019

Also we should add tests for this functionality. It's pretty central and was missing before.

@riarenas riarenas mentioned this issue Sep 13, 2019
Closed
@mmitche mmitche assigned JohnTortugo and unassigned mmitche Sep 16, 2019
@JohnTortugo JohnTortugo mentioned this issue Sep 16, 2019
Merged
This was referenced Sep 19, 2019
Closed
Closed
@dagood
Copy link
Member

dagood commented Sep 19, 2019 •
edited
Loading

When can we expect the fix live? I see some discussion about this not being a patch to prod in dotnet/arcade-services#640, but what does that mean?

This makes auto-update PRs require manual intervention in Core-Setup. (All branches.)

/cc @wtgodbe

@riarenas
Copy link
Member Author

We are actually planning a Production rollout for today, so we'll wait for that PR to go in, and we'll proceed to roll it out if everything looks good after it gets merged.

@riarenas
Copy link
Member Author

And just to set expectations. This might have to wait until Monday if we're not able to roll out today.

@riarenas riarenas reopened this Sep 19, 2019
@riarenas
Copy link
Member Author

Reopening. This should be in rollout.

This was referenced Sep 20, 2019
Merged
Merged
Closed
@riarenas
Copy link
Member Author

This was rolled out.

@dagood dagood mentioned this issue Nov 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTortugo JohnTortugo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve comments and elements order in Nuget.Config dotnet/arcade-services
4 participants
@JohnTortugo @mmitche @dagood @riarenas