[Mono.Android] delay JNINativeWrapper.get_runtime_types() #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewing `dotnet-trace` output, I noticed in a `dotnet new maui` app
on a Pixel 5:
6.38ms mono.android!Android.Runtime.JNINativeWrapper.CreateDelegate(System.Delegate)
1.16ms mono.android!Android.Runtime.JNINativeWrapper.get_runtime_types()
We spend ~1ms looking up `AndroidEnvironment.UnhandledException` and
`AndroidRuntimeInternal.WaitForBridgeProcessing`.
However, in this app *all* calls go to the "fast path" via
`JNINativeWrapper.CreateBuiltInDelegate()`. We don't *need* to look up
these methods in this app at all.
Delay the call to `get_runtime_types()` to only when it is needed via
the "slow path". Will help us a small amount in .NET 8.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 24, 2023
* main: [Xamarin.Android.Build.Tasks] Fix native code generation when marshal methods are disabled (dotnet#7899) [ci] Optimize 'APK's .NET' test job overhead. (dotnet#7904) [Mono.Android] delay JNINativeWrapper.get_runtime_types() (dotnet#7913) Bump external/Java.Interop from `73ebad2` to `53bfb4a` (dotnet#7914)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Apr 6, 2023
* main: (94 commits) [ci] Remove remaining Classic test jobs. (dotnet#7924) Add Nightly Tests for Humanizer [readme] Add aka.ms links for d17.5. (dotnet#7935) [tests] Remove `net472` multitargeting (dotnet#7932) [monodroid] Fix `ld` build error on Nightly Builds. (dotnet#7925) Bump to xamarin/Java.Interop/main@0355acf (dotnet#7931) [tests] Use msftconnecttest.com in QuoteInvalidQuoteUrlsShouldWork (dotnet#7919) [ci] Don't set demands for megapipeline (dotnet#7929) [Mono.Android] Bind API-UpsideDownCake Developer Preview 1 (dotnet#7796) Bump to dotnet/installer@d109cba3ff 8.0.100-preview.4.23176.5 (dotnet#7921) [Xamarin.Android.Build.Tasks] Fix Android Version Code for Release builds (dotnet#7795) Bump to dotnet/installer@27d6769dfb 8.0.100-preview.4.23172.16 (dotnet#7910) [Xamarin.Android.Build.Tasks] Fix native code generation when marshal methods are disabled (dotnet#7899) [ci] Optimize 'APK's .NET' test job overhead. (dotnet#7904) [Mono.Android] delay JNINativeWrapper.get_runtime_types() (dotnet#7913) Bump external/Java.Interop from `73ebad2` to `53bfb4a` (dotnet#7914) [build] remove .NET 6 support (dotnet#7900) [profiled-aot] update `dotnet.aotprofile` for .NET 8 (dotnet#7908) [tests] Add backup ssl sites in case of 429 response. (dotnet#7909) $(AndroidPackVersionSuffix)=preview.4; net8 is 34.0.0-preview.4 (dotnet#7912) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing
dotnet-traceoutput, I noticed in adotnet new mauiapp on a Pixel 5:We spend ~1ms looking up
AndroidEnvironment.UnhandledExceptionandAndroidRuntimeInternal.WaitForBridgeProcessing.However, in this app all calls go to the "fast path" via
JNINativeWrapper.CreateBuiltInDelegate(). We don't need to look up these methods in this app at all.Delay the call to
get_runtime_types()to only when it is needed via the "slow path". Will help us a small amount in .NET 8.