Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono.Android] Update api-compat reference file. #7822

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[Mono.Android] Update api-compat reference file. #7822

merged 1 commit into from
Feb 22, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Feb 22, 2023

Before we start building API-34 previews for Mono.Android.dll, let's update our api-compat reference file for the current API-33. This will help make it clearer any breakages for API-34.

Mainly this updates for all of the [ObsoleteOSPlatform] fixes we have made over the past few months.

Additionally, the reference file is now based on a .NET Mono.Android.dll instead of a Classic Mono.Android.dll, so additional framework dependent changes will no longer have to be tracked in "acceptable breakages".

As a result, there would need to be fixups made to the Classic api-compat breakage file, but as we are in the process of removing Classic from main, we simply disable the api-compat check when building Classic Mono.Android.dll for now.

@jpobst jpobst marked this pull request as ready for review February 22, 2023 19:01
@jonpryor jonpryor merged commit ebd7dff into main Feb 22, 2023
@jonpryor jonpryor deleted the api-33-ref branch February 22, 2023 19:29
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 23, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
  Add Unit Test for testOnly apps (dotnet#7637)
  [build] Only build the latest API level (dotnet#7786)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 24, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
  Add Unit Test for testOnly apps (dotnet#7637)
  [build] Only build the latest API level (dotnet#7786)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 24, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 24, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 24, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 24, 2023
* main:
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
  Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 27, 2023
* main:
  Localized file check-in by OneLocBuild (dotnet#7827)
  Revert "Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)"
  LEGO: Merge pull request 7828
  LEGO: Merge pull request 7825
  Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799)
  Bump NDK to r25c (dotnet#7808)
  [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816)
  [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants