-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Remove some Classic XA test stages/jobs. #7770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
requested review from
jonathanpeppers,
pjcollins and
jonpryor
and removed request for
jonpryor and
pjcollins
February 7, 2023 02:08
jonathanpeppers
approved these changes
Feb 7, 2023
pjcollins
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look at the tests we ignore in the .NET runs and don't think this would cause us to lose much coverage. I filed #7777 to take a closer look and port any important tests in the near-ish future.
jonathanpeppers
pushed a commit
that referenced
this pull request
Feb 9, 2023
Super easy win to kick off removing Classic from `main`: Remove the `Legacy Tests` stage and `MSBuild+Emulator Legacy #X` jobs. These definitely are already running .NET equivalents, and will reduce our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 10, 2023
* main: [ci] Remove some Classic XA test stages/jobs. (dotnet#7770)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 10, 2023
* main: [ci] Remove some Classic XA test stages/jobs. (dotnet#7770) [ci] Remove classic Mono.Android-Tests runs (dotnet#7778) $(AndroidPackVersionSuffix)=preview.2; net8 is 34.0.0-preview.2 (dotnet#7761) Localized file check-in by OneLocBuild Task (dotnet#7758)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 10, 2023
* main: [ci] Remove some Classic XA test stages/jobs. (dotnet#7770)
jonathanpeppers
pushed a commit
that referenced
this pull request
Feb 15, 2023
Super easy win to kick off removing Classic from `main`: Remove the `Legacy Tests` stage and `MSBuild+Emulator Legacy #X` jobs. These definitely are already running .NET equivalents, and will reduce our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super easy win to kick off removing Classic from
main
:Remove the
Legacy Tests
stage andMSBuild+Emulator Legacy #X
jobs.These definitely are already running .NET equivalents, and will reduce our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).