Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove some Classic XA test stages/jobs. #7770

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Feb 6, 2023

Super easy win to kick off removing Classic from main:

Remove the Legacy Tests stage and MSBuild+Emulator Legacy #X jobs.

These definitely are already running .NET equivalents, and will reduce our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).

@jpobst jpobst marked this pull request as ready for review February 7, 2023 02:08
@jpobst jpobst requested review from jonathanpeppers, pjcollins and jonpryor and removed request for jonpryor and pjcollins February 7, 2023 02:08
Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look at the tests we ignore in the .NET runs and don't think this would cause us to lose much coverage. I filed #7777 to take a closer look and port any important tests in the near-ish future.

@pjcollins pjcollins merged commit 4558c0e into main Feb 9, 2023
@pjcollins pjcollins deleted the remove-classic-stages branch February 9, 2023 21:21
jonathanpeppers pushed a commit that referenced this pull request Feb 9, 2023
Super easy win to kick off removing Classic from `main`:

Remove the `Legacy Tests` stage and `MSBuild+Emulator Legacy #X` jobs.

These definitely are already running .NET equivalents, and will reduce
our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 10, 2023
* main:
  [ci] Remove some Classic XA test stages/jobs. (dotnet#7770)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 10, 2023
* main:
  [ci] Remove some Classic XA test stages/jobs. (dotnet#7770)
  [ci] Remove classic Mono.Android-Tests runs (dotnet#7778)
  $(AndroidPackVersionSuffix)=preview.2; net8 is 34.0.0-preview.2 (dotnet#7761)
  Localized file check-in by OneLocBuild Task (dotnet#7758)
grendello added a commit to grendello/xamarin-android that referenced this pull request Feb 10, 2023
* main:
  [ci] Remove some Classic XA test stages/jobs. (dotnet#7770)
jonathanpeppers pushed a commit that referenced this pull request Feb 15, 2023
Super easy win to kick off removing Classic from `main`:

Remove the `Legacy Tests` stage and `MSBuild+Emulator Legacy #X` jobs.

These definitely are already running .NET equivalents, and will reduce
our CI per-run cost by ~11.5 CPU hours (out of ~39.5 hours total).
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants