Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move build stages into yaml templates #7553

Merged
merged 8 commits into from
Jan 19, 2023
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Nov 11, 2022

Context: https://github.com/xamarin/sdk-insertions/pull/42
Context: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=17671&_a=summary

As part of efforts to create an integration and release pipeline for all
of MAUI we will want to "templatize" more of our YAML. Our three build
stages have been moved into new templates that can be referenced by the
MAUI "mega pipeline".

As part of efforts to create an integration and release pipeline for all
of MAUI we will want to "templatize" more yaml.
@pjcollins pjcollins marked this pull request as ready for review January 17, 2023 21:35
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks "the same". Is there anything here that changed in a significant way?

Otherwise moving these to templates seems fine for what we need to do in the unitified build pipeline.

@pjcollins
Copy link
Member Author

Everything looks "the same". Is there anything here that changed in a significant way?

The only minor change here should be that the - checkout: self step has been replaced with https://github.com/xamarin/yaml-templates/blob/main/sdk-unified/steps/checkout/v1.yml, otherwise the rest of the YAML has just been moved around and further parameterized.

@pjcollins pjcollins merged commit b5d1d22 into main Jan 19, 2023
@pjcollins pjcollins deleted the dev/pjc/net-job-templates branch January 19, 2023 15:20
pjcollins added a commit that referenced this pull request Jan 19, 2023
Context: xamarin/sdk-insertions#42
Context: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=17671&_a=summary

As part of efforts to create an integration and release pipeline for all
of MAUI we will want to "templatize" more of our YAML.  Our three build
stages have been moved into new templates that can be referenced by the
MAUI "mega pipeline".
pjcollins added a commit that referenced this pull request Jan 20, 2023
Context: xamarin/sdk-insertions#42
Context: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=17671&_a=summary

As part of efforts to create an integration and release pipeline for all
of MAUI we will want to "templatize" more of our YAML.  Our three build
stages have been moved into new templates that can be referenced by the
MAUI "mega pipeline".

In an attempt to unify the build for all the SDKs we need to rename all
the resources to use the same names.

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
grendello added a commit to grendello/xamarin-android that referenced this pull request Jan 26, 2023
* main: (32 commits)
  [monodroid] Replace `exit()` with `abort()` in native code (dotnet#7734)
  Bump to xamarin/Java.Interop/main@8a1ae57 (dotnet#7738)
  [build] bump `$(AndroidNet7Version)` (dotnet#7737)
  Bump to xamarin/Java.Interop/main@1366d99 (dotnet#7718)
  [Xamarin.Android.Build.Tasks] fix AndroidGenerateResourceDesigner (dotnet#7721)
  Bump to xamarin/monodroid@50faac94 (dotnet#7725)
  Revert "[Xamarin.Android.Build.Tasks] fix cases of missing `@(Reference)` (dotnet#7642)" (dotnet#7726)
  [marshal methods] Properly support arrays of arrays (dotnet#7707)
  Bump to dotnet/installer@9962c6a 8.0.100-alpha.1.23063.11 (dotnet#7677)
  [Actions] Add action to bump the hash used for the unified pipeline (dotnet#7712)
  Bump to xamarin/xamarin-android-tools/main@099fd95 (dotnet#7709)
  [ci] Move build stages into yaml templates (dotnet#7553)
  [Xamarin.Android.Build.Tasks] fix NRE in `<GenerateResourceCaseMap/>` (dotnet#7716)
  [ci] Pass token when building Designer tests (dotnet#7715)
  [Mono.Android] Android.Telecom.InCallService.SetAudioRoute() + enum (dotnet#7711)
  [Mono.Android] Fix some incorrect enums. (dotnet#7670)
  [Xamarin.Android.Build.Tasks] _Microsoft.Android.Resource.Designer namespace (dotnet#7681)
  LEGO: Merge pull request 7713
  [Xamarin.Android.Build.Tasks] lazily populate Resource lookup (dotnet#7686)
  [Xamarin.Android.Build.Tasks] skip XA1034 logic in some cases (dotnet#7680)
  ...
grendello added a commit to grendello/xamarin-android that referenced this pull request Jan 30, 2023
* main:
  [marshal methods] Properly support arrays of arrays (dotnet#7707)
  Bump to dotnet/installer@9962c6a 8.0.100-alpha.1.23063.11 (dotnet#7677)
  [Actions] Add action to bump the hash used for the unified pipeline (dotnet#7712)
  Bump to xamarin/xamarin-android-tools/main@099fd95 (dotnet#7709)
  [ci] Move build stages into yaml templates (dotnet#7553)
  [Xamarin.Android.Build.Tasks] fix NRE in `<GenerateResourceCaseMap/>` (dotnet#7716)
  [ci] Pass token when building Designer tests (dotnet#7715)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants