[linker] Make sure we mark *Invoker types #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#3263 Looks like dotnet@5b945ab introduced a new regression, where in some cases we were not marking the *Invoker type anymore, as [this line](dotnet@5b945ab#diff-144727b152107ec306fbe284bd5902e3L60) is gone. This is fixed by marking the *Invoker types in MarkJavaObjects step.
|
The |
jonathanpeppers
approved these changes
Jul 18, 2019
jonpryor
pushed a commit
that referenced
this pull request
Jul 19, 2019
[linker] Make sure we mark *Invoker types Fixes #3263 Looks like 5b945ab introduced a new regression, where in some cases we were not marking the *Invoker type anymore, as [this line](5b945ab#diff-144727b152107ec306fbe284bd5902e3L60) is gone. This is fixed by marking the *Invoker types in MarkJavaObjects step. Added test to Mono.Android runtime test, which should catch the issue if it happens again.
jonpryor
pushed a commit
that referenced
this pull request
Jul 31, 2019
[linker] Make sure we mark *Invoker types Fixes #3263 Looks like 5b945ab introduced a new regression, where in some cases we were not marking the *Invoker type anymore, as [this line](5b945ab#diff-144727b152107ec306fbe284bd5902e3L60) is gone. This is fixed by marking the *Invoker types in MarkJavaObjects step. Added test to Mono.Android runtime test, which should catch the issue if it happens again.
|
The problem reported in #3263 happens again with VS 17.2.3 using a .NET 6 Android application. |
|
@tipa we still use this same linker step in .NET 6: But if you have an example that breaks, file an issue, and we can take a look. Thanks! I recall you might be using |
|
It also crashes when not using I opened a new issue with a demo project here: #7097 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3263
Looks like
5b945ab
introduced a new regression, where in some cases we were not marking
the *Invoker type anymore, as this line
is gone.
This is fixed by marking the *Invoker types in MarkJavaObjects step.