Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspicious comment about non-existing lock in System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning() #92

Closed
Dmitry-Me opened this issue Feb 15, 2016 · 2 comments

Comments

@Dmitry-Me
Copy link

System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning() has this warning:

  // call OnError outside of _ErrorCollectionLock to avoid deadlock

there's nothing called _ErrorCollectionLock or similarly in the codebase. The comment is full of magic.

@saurabh500 saurabh500 removed their assignment Mar 24, 2017
@divega divega transferred this issue from dotnet/corefx May 16, 2019
@divega
Copy link

divega commented May 16, 2019

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

@JRahnama
Copy link
Contributor

Closing as PR#684 is merged and it will be in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants