-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any reason installing SqlClient should bring WebView2? #2298
Comments
Is the WebView2 dll included when you publish the app. It comes from Azure.Identity, but only when targeting net6.0-windows7.0 |
|
I just created a sample application with net8 and was not able to see that reference. As @ErikEJ has mentioned it will be mapped when targeting net6.0-windows7.0. Can you share the csproj? |
The csproj only has |
@R2D221 what if you target net8.0 ONLY? |
Give me a moment and I'll test it |
This seems to be by design... |
What is by design? Bring a GUI dependency on my console project? I don't think I follow |
If it was a true console project you would not need net8.0-windows |
I have a dependency on System.DirectoryServices for some Active Directory stuff. That still doesn't invoke any UI of any kind, but the package gives warnings about the only supported platform being Windows, so I made my project Windows-only. |
But anyway, even when I'm using SqlClient on WPF projects, I still don't need the WebView2 component since I'm not showing any HTML stuff. |
same situation is with System.Drawing.Common Microsoft.Data.SqlClient is dependant on System.Runtime.Caching which is dependant on System.Configuration.ConfigurationManager which is dependant on System.Security.Permissions which is dependant on System.Windows.Extensions which is dependant on System.Drawing.Common it is only db driver |
Microsoft.Identity.Client is MSAL. It provides AAD authentication, including interactive auth. I'd guess those libraries are included to provide a nicer interactive experience on Windows and/or WAM integration, versus the typical browser popup implementation. This dependency chain isn't something we have control over in MDS. |
Describe the bug
I just updated the Microsoft.Data.SqlClient package to version 5.1.4. After that, in the list of transitive packages it shows the following:
To reproduce
Just install Microsoft.Data.SqlClient 5.1.4 in a console project.
Expected behavior
A GUI component shouldn't be part of the dependencies for a database library.
Further technical details
Microsoft.Data.SqlClient version: 5.1.4
.NET target: 8.0
SQL Server version: -
Operating system: Windows 10 21H2
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: