Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and validate data binding experiences with WPF and Windows Forms #2661

Closed
ajcvickers opened this issue Jan 3, 2019 · 3 comments
Closed

Comments

@ajcvickers
Copy link
Contributor

Especially targeting .NET Core 3.0

Things to consider:

@sjb-sjb
Copy link

sjb-sjb commented Jan 4, 2019

A few comments based on my experience with notification entities.

  • Would certainly suggest including UWP in the platform list. I believe the issues are similar.
  • Broadly speaking it makes sense to use notification entities in a UI application because notifications are needed anyway to push info to the UI.
  • Since @ajcvickers alluded to "correctly implementing" notification entities,let me ask, is there a known problem?
  • Concerning "What to bind to", my personal opinion is that Microsoft should build a complete view model system that integrates with EF. This should include paging appropriate for data virtualizing list view. Also a view model system for individual properties including property errors -- perhaps along the lines of the Template 10 view models.
  • I didn't have any problem configuring EF to use notification entities.
  • Concerning store generated values, the questions are different for Id's than for, say, concurrency tokens. As I recall, if I notify a change to an Id after a SaveChanges then EF throws an error saying that the primary key cannot be set at that time.
  • Overall it seems to me that some clarity should be brought to the timing of property change notifications and how these might interact with entity state change notifications. Are there restrictions in setting/notifying properties within state change callbacks? How long after setting a field can we notify the property change?
  • In my implementation I did end up setting EF to write to fields. It was too difficult otherwise to sort out what property notifications were coming from EF vs my application. I wonder if it would make sense to consider having a separate event from EF when a field assignment occurs -- i.e. DbContext.FieldChanged rather than entity.PropertyChanged. It goes with the theme of lifecycle hooks.

@ajcvickers ajcvickers removed their assignment May 10, 2019
@ajcvickers
Copy link
Contributor Author

Smoke test only for 3.0

@ajcvickers ajcvickers transferred this issue from dotnet/efcore Sep 17, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Sep 18, 2020
@bricelam bricelam removed their assignment Oct 6, 2020
@ajcvickers
Copy link
Contributor Author

Tracking as part of #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants