Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptive attributes to _bitfield properties that indicate the original name and size of the fields they represent #435

Closed
mikebattista opened this issue Mar 20, 2023 · 3 comments · Fixed by #442

Comments

@mikebattista
Copy link

See microsoft/win32metadata#1392 (comment).

@mikebattista mikebattista changed the title Add descriptive attributes to _bitfield properties that indicate the original name and size of the field they represent Add descriptive attributes to _bitfield properties that indicate the original name and size of the fields they represent Mar 23, 2023
@mikebattista
Copy link
Author

mikebattista commented Mar 23, 2023

As shown in the example linked above, these _bitfield properties tend to represent more than one property. Each bitfield represents 32 bits and the helper functions you currently generate modify the corresponding bits in the bitfield.

How are you thinking of describing that here?

@tannergooding
Copy link
Member

[NativeBitfield("InstanceId", Offset = 0, Length = 24)] and simply ensuring the attribute is AllowMultiple = true.

@mikebattista
Copy link
Author

Perfect. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants