Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Update generated path for schema.graphql #171

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Update generated path for schema.graphql #171

merged 1 commit into from
Jul 25, 2020

Conversation

daadaadaah
Copy link
Contributor

Specify project

Server

Description

How about you changing the generated path for schema.graphql from /server to /server/src/generated?

I think it is better to manage everything generated by nexus in the generated folder at once.

In the previous project, it was managed in one place.

If you have any other opinion, please speak freely.

Tests

None

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files          24       24           
  Lines         448      448           
  Branches       33       33           
=======================================
  Hits          305      305           
  Misses        130      130           
  Partials       13       13           
Impacted Files Coverage Δ
server/src/schema.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62df60f...296909b. Read the comment docs.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ah! Nice catch. This has been changed since after we've migrated to Prisma2.

@hyochan hyochan merged commit 9661ca3 into hyochan:master Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants