Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ButtonGroup component storybook docs rendering error #64

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Fix ButtonGroup component storybook docs rendering error #64

merged 1 commit into from
Aug 10, 2021

Conversation

alstn2468
Copy link
Contributor

@alstn2468 alstn2468 commented Aug 10, 2021

Description

Fixed a rendering error in the storybook document of the ButtonGroup component.

Solution: install babel-plugin-react-require
The package has not been maintained for a long time, so I'm not sure if it's the right way to actually use it.
However, this package became the solution to issue #60.

Related Issues

[ButtonGroup] docs not rendering. (#60)

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

Solution: install babel-plugin-react-require
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #64 (79a2a39) into master (f41047a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files          21       21           
  Lines         554      554           
  Branches      235      235           
=======================================
  Hits          522      522           
  Misses         32       32           

@hyochan hyochan added 🍗 enhancement New feature or request 🛠 bugfix All kinds of bug fixes labels Aug 10, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!!

It looks like a problem with an old storybook version that uses react version under 17. We can remove this when upgraded.

@hyochan hyochan merged commit 9cff6a6 into hyochan:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants