Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What motivates the complicated dance for NewPromiseCapability? #104

Open
domenic opened this issue Apr 7, 2014 · 2 comments
Open

What motivates the complicated dance for NewPromiseCapability? #104

domenic opened this issue Apr 7, 2014 · 2 comments
Assignees
Labels

Comments

@domenic
Copy link
Owner

domenic commented Apr 7, 2014

@allenwb, would appreciate your help on this.

Back in https://github.com/domenic/promises-unwrapping/tree/a3a8a88c9091a009be7d2320cf0e590317db5956, we had a very simple GetDeferred + Deferred Construction Functions pair. Now we have a complicated dance involving NewPromiseCapability, CreatePromiseCapabilityRecord, and GetCapabilitiesExecutor Functions, each of which is much longer than either of their previous counterparts, and all of which contain extensive invariant checks and tricks.

To make matters worse, from what I can tell the checks introduced there are at the root of the problems @cscott is experiencing with bugs like #94 and #95.

What have we gained with the new system, and can you see a way of fixing it to fix those bugs? I would much rather just revert to the old system if that's possible.

@domenic
Copy link
Owner Author

domenic commented Apr 19, 2014

Ping @allenwb

@domenic
Copy link
Owner Author

domenic commented Jul 31, 2014

Assigning back to me. Action item: figure out what, if any, observable differences there are between the previous version and the current one. That will help resolve #94 and #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants