Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRCode box overlay #80

Open
aabanaag opened this issue May 29, 2018 · 2 comments
Open

QRCode box overlay #80

aabanaag opened this issue May 29, 2018 · 2 comments

Comments

@aabanaag
Copy link

Is it possible to implement an overlay to show where the qrcode is in the camera feed? just like this https://www.appcoda.com/barcode-reader-swift/

Was wondering how can I get the videoPreviewLayer of the camera so I can use transformedMetadataObject

@dokun1
Copy link
Owner

dokun1 commented May 29, 2018

Hi @aabanaag - thanks for your comment!

So, funny enough, this existed in a previous pre-release build of Lumina. You can see the source code here.

I think I abandoned this because I got a bit obsessed with implementing the other newer stuff and re-organizing the architecture, and this didn't fit in immediately, especially differentiating between face detection and QR code detection. Also, I didn't see an immediate need for drawing a rect around it as detecting it was more necessary.

However, if there's a need for it, then I can definitely look at putting it back in 👍 let me know your thoughts.

@aabanaag
Copy link
Author

well, initially I thought it would be needed as you can basically track the metadata within the camera feed but I think the best way to do it is add toggle for it because just like the native camera of the iPhone it doesn't track the qrcode. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants