Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Consider making WidgetBase abstract and not implementing render #712

Open
agubler opened this issue Oct 9, 2017 · 2 comments
Open

Consider making WidgetBase abstract and not implementing render #712

agubler opened this issue Oct 9, 2017 · 2 comments

Comments

@agubler
Copy link
Member

agubler commented Oct 9, 2017

Enhancement

We should consider making WidgetBase abstract and not implementing the render method. There isn't really a use-case to for WidgetBase to not be extended and making it abstract would ensure that the render method is correctly implemented by sub classes.

@kitsonk
Copy link
Member

kitsonk commented Oct 9, 2017

There was a time where I disliked the concept of abstract in TypeScript, given interfaces, but I have realised over time, something like WidgetBase is perfect for that sort of concept. No one should ever use it directly, therefore, it is, in its own right, an abstract class.

@kitsonk kitsonk added this to the 2017.10 milestone Oct 9, 2017
@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@kitsonk kitsonk added beta5 and removed beta4 labels Oct 30, 2017
@kitsonk kitsonk modified the milestones: beta.4, beta.5 Oct 30, 2017
@kitsonk
Copy link
Member

kitsonk commented Oct 30, 2017

I think this is 👍, scheduling for beta5.

@agubler agubler removed the beta5 label Jan 4, 2018
@agubler agubler removed this from the beta.5 milestone Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants