Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompoundColumns adds extra columns to dgrid when using IE8 and Ecmascript 5 shims #624

Closed
gregington opened this issue Jun 13, 2013 · 2 comments

Comments

@gregington
Copy link

When using a dgrid with compound columns, a number of extra columns are added to the drid when running with IE8 whilst also using an Ecmascript 5 shim, such as one found at https://github.com/kriskowal/es5-shim.

This is because of a for-in loop that is iterating through the columns array and not using hasOwnProperty. The functions added to the Array prototype are also included in the iteration and result in extra columns.

@gregington
Copy link
Author

Added pull request with a fix.

@ghost ghost closed this as completed in ffed948 Jul 29, 2013
@kfranqueiro
Copy link
Member

Thanks for the report. The tricky part of this issue is that columns can be specified either as an array or an object. However, for cases where it is specified as an array, we really shouldn't be using a for-in loop. I've revised the code in two paths I found to be affected by such practices.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants