Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm audit issues #934

Merged
merged 1 commit into from
Oct 16, 2019
Merged

fix: npm audit issues #934

merged 1 commit into from
Oct 16, 2019

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Oct 12, 2019

Summary
Fixed npm audit issues by updating packages

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No
  • Not sure

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@felangel felangel merged commit 615205c into docsifyjs:develop Oct 16, 2019
@L2jLiga L2jLiga deleted the audit-fix branch October 16, 2019 13:41
@L2jLiga
Copy link
Contributor Author

L2jLiga commented Oct 27, 2019

@felangel, @timaschew are you going to release new version?

@felangel
Copy link
Contributor

@timaschew whats the process for releasing?

@anikethsaha
Copy link
Member

@felangel any update on this release ?

@anikethsaha
Copy link
Member

We need this for master and then release it

@timaschew
Copy link
Member

@timaschew whats the process for releasing?

  1. merge to master
  2. run build/release.sh (you need permission on npm)

Let's add this to the https://github.com/docsifyjs/docsify/blob/develop/CONTRIBUTING.md

@decompil3d
Copy link

Hi folks -- is there a plan to get this released soon? Dependent packages are getting GitHub security alerts because of the old version of marked used in the latest published version. Thanks in advance for your help!

@anikethsaha
Copy link
Member

Sorry for the delay, It will be released soon. need some time for this.

cc @felangel @timaschew

@anikethsaha
Copy link
Member

@decompil3d
Copy link

Thank you @anikethsaha 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants