Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vue3 #1364

Closed
nichtich opened this issue Aug 28, 2020 · 2 comments · Fixed by #1271
Closed

Support Vue3 #1364

nichtich opened this issue Aug 28, 2020 · 2 comments · Fixed by #1271
Labels
enhancement vuejs related to Vue.js

Comments

@nichtich
Copy link

Feature request

What problem does this feature solve?

Docsify does not work with Vue3 because in Vue3 there is no global app. This results in error

Uncaught TypeError: window.Vue is not a constructor

What does the proposed API look like?

When using Vue3, you have to manually initialize a Vue instance because no default instance is created.

It would also be possible to create a default instance with Vue3 but I need to configure my own instance anyway.

How should this be implemented in your opinion?

Add an additional condition Vue.version.split(".")[0]<=2 and don't call Vue().$mount if it is false.

Are you willing to work on this yourself?

I can provide a pull request if the proposed solution is ok to you.

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Oct 7, 2020

Address in #1271. Waiting for review and merge.

@jhildenbiddle jhildenbiddle linked a pull request Oct 8, 2020 that will close this issue
@jhildenbiddle
Copy link
Member

@nichtich --

Added in #1271. Updated docs are available here: https://github.com/docsifyjs/docsify/blob/develop/docs/vue.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vuejs related to Vue.js
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants