Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect log output detection #59

Closed
lmakarov opened this issue Jan 11, 2020 · 1 comment
Closed

Incorrect log output detection #59

lmakarov opened this issue Jan 11, 2020 · 1 comment
Assignees
@lmakarov
Labels
bug

Comments

@lmakarov
Copy link
Member

Some servers (e.g. webpack-dev-server) may output a few blank lines in the logs after it's done initializing causing vhost-proxy to not see output on the last line of the logs and consider the project inactive. This causes project stack stopped within 60s of initialization on a docksal/sandbox-server.

Checking for 5 instead of 1 last lines addresses this issue.
@lmakarov lmakarov added the bug label Jan 11, 2020
@lmakarov lmakarov self-assigned this Jan 11, 2020
@lmakarov
Copy link
Member Author

Fixed in 2491ea8

@lmakarov lmakarov mentioned this issue Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmakarov lmakarov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmakarov