Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended wildcard support for virtual host names #25

Open
lmakarov opened this issue May 23, 2018 · 0 comments
Open

Extended wildcard support for virtual host names #25

lmakarov opened this issue May 23, 2018 · 0 comments

Comments

@lmakarov
Copy link
Member

lmakarov commented May 23, 2018

We currently support projects matching the following virtual host rules:

  • exact match: example.com (code)
  • wildcard match with multiple values: example.com,*.example.com,example2.com (code)

This is a proposal to support *.VIRTUAL_HOST.* wildcards (single and/or multi-value options).

nginx does not support this kind of wildcard, but does support regexp virtual hosts:
http://nginx.org/en/docs/http/server_names.html
For nginx, the virtual host would need to be defined as: ^(.+\.)?VIRTUAL_HOST_ESCAPED(\..+)?$

In proxyctl we will also have to make changes to the logic handling project lookup in the start() function.

Once implemented, this will simplify the sandboxing use case, as it will no longer be necessary to adjust project's VIRTUAL_HOST settings to add the base domain for the sandbox environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant