Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DNS resolution of *.local in favor of DOCKSAL_DNS_DOMAIN #2

Closed
gmta opened this issue Jul 30, 2018 · 6 comments
Closed

Remove DNS resolution of *.local in favor of DOCKSAL_DNS_DOMAIN #2

gmta opened this issue Jul 30, 2018 · 6 comments
Assignees

Comments

@gmta
Copy link

gmta commented Jul 30, 2018

Currently service-dns resolves all requests to *.local to 127.0.0.1. It would be nice to be able to disable or rename the .local DNS zone.

Use case: we use *.company.local as an internal DNS zone, which conflicts with this service's configuration. As a workaround, we now build a specific DNS container image where we empty out the configuration file for the .local zone.

Suggested fixes:

  • Support disabling this zone, e.g. DNS_LOCAL_ZONE_ENABLED=false
  • Support renaming this zone, e.g. DNS_LOCAL_ZONE=something-else-entirely
  • Leave out this additional zone since there are valid alternatives such as .docksal or localhost to connect to other services.
@gmta
Copy link
Author

gmta commented Jul 30, 2018

By the way, I understand that it's not really a smart idea to use an internal DNS zone ending in .local for a multitude of reasons - but it's legacy :-)

@achekulaev
Copy link
Member

Docksal provides resolution for .docksal. What is .local?

@gmta
Copy link
Author

gmta commented Jul 30, 2018

Please look here:
42b64a7#diff-b958f585a04af5ee2087610ea7180f34R15

@achekulaev
Copy link
Member

Whoa!.. @lmakarov do we even need this?

@lmakarov
Copy link
Member

lmakarov commented Jul 30, 2018

.local was added a while ago to support people with "legacies". Those, that did not want to use .docksal and wanted .local instead. I don't think this feature was ever advertised, so it may be fine to remove it. Adding to the next release backlog.

@achekulaev
Copy link
Member

achekulaev commented Jul 30, 2018

@lmakarov got it. Well DOCKSAL_DNS_DOMAIN is configurable for some time now, so those people who need it will be able to use local.

@gmta gmta changed the title Make resolution of *.local to 127.0.0.1 configurable Remove DNS resolution of *.local names in favor of DOCKSAL_DNS_DOMAIN Jul 31, 2018
@gmta gmta changed the title Remove DNS resolution of *.local names in favor of DOCKSAL_DNS_DOMAIN Remove DNS resolution of *.local in favor of DOCKSAL_DNS_DOMAIN Jul 31, 2018
@lmakarov lmakarov mentioned this issue Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants