Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] Fix possible runtime panic in Lgetxattr #454

Merged

Conversation

thaJeztah
Copy link
Member

If unix.Lgetxattr returns an error, then sz == -1 which will cause a
runtime panic if errno == unix.ERANGE.

backport of moby#40283

If `unix.Lgetxattr` returns an error, then `sz == -1` which will cause a
runtime panic if `errno == unix.ERANGE`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
(cherry picked from commit 4138cd2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.6 milestone Jan 22, 2020
Copy link

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link

[2020-01-22T18:05:17.584Z] warning: PID 7365 from bundles/test-integration/TestDockerDaemonSuite/TestFailedPluginRemove/dd8e2a0cf267b/docker.pid had a nonzero exit code

@thaJeztah
Copy link
Member Author

kicked it once more, will merge on green

@tonistiigi tonistiigi merged commit 69098f0 into docker-archive:19.03 Jan 23, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_lgetxattr_panic branch January 23, 2020 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants