This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Increase max recv gRPC message size for nodes and secrets #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the max recieved gRPC message size for Node and Secret list operations. This has already been done for the other swarm types, but was not done for these. Signed-off-by: Drew Erny <drew.erny@docker.com> (cherry picked from commit a0903e1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @kolyshkin @dperny PTAL |
|
LGTM |
|
Windows RS1 failure is unrelated, and test is known to be broken currently |
thaJeztah
changed the title
|
marking "WIP" while upstream hasn't been merged yet 😞 |
|
Upstream is merged as of 8 minutes ago 🎉 |
thaJeztah
changed the title
|
bringing this one in; cherry-pick was clean |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#39306 for 19.03
Increases the max recieved gRPC message size for Node and Secret list
operations. This has already been done for the other swarm types, but
was not done for these.