[1.13] Update go connections 1.13 #30730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cyli PTAL |
dmcgowan
force-pushed
the
update-go-connections-1.13
branch
from
a476f85
to
441a7f5
Compare
|
LGTM Also noting that @dmcgowan and I discussed cleaning up the messaging in docker to make it clear why we are unable to use the system root (because the user has specifically configured a custom root, which takes precedence), so it doesn't look like some maybe scary thing in the logs. |
fixes moby#30450 Signed-off-by: Derek McGowan <derek@mcgstyle.net>
dmcgowan
force-pushed
the
update-go-connections-1.13
branch
from
441a7f5
to
b47fa5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes windows message about system certificates from warn to info level. Ensures that server does not attempt to load an empty ca file.
fixes #30450
Like #30729 but against 1.13. Uses https://github.com/docker/go-connections/tree/docker/1.13 instead of master which only contains windows fix.