Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARGs for cross compiling #2209

Closed
wants to merge 4 commits into from
Closed

Add ARGs for cross compiling #2209

wants to merge 4 commits into from

Conversation

sixeyed
Copy link
Contributor

@sixeyed sixeyed commented Mar 7, 2017

Bump Go to 1.8 and add build args. Defaults to Linux/x64 but can build for other platforms - e.g.

docker build --build-arg GOOS=windows -t distribution-builder:windows .

Signed-off-by: Elton Stoneman <elton@sixeyed.com>
@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

Merging #2209 into master will decrease coverage by 10.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2209       +/-   ##
==========================================
- Coverage   61.57%   51.5%   -10.08%     
==========================================
  Files         125     125               
  Lines       11397   11397               
==========================================
- Hits         7018    5870     -1148     
- Misses       3493    4781     +1288     
+ Partials      886     746      -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.57% <0%> (-56.23%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.4%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a528cc1...87b2b37. Read the comment docs.

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM golang:1.7-alpine
FROM golang:1.8-alpine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we are quite on 1.8 yet.

@stevvooe
Copy link
Collaborator

stevvooe commented Apr 5, 2017

Thanks for the fix!

We aren't quite on 1.8 yet, so if you could leave the Dockerfile on 1.7, we can get this merged.

@dmcgowan dmcgowan added this to the Registry/2.7 milestone Apr 10, 2017
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:sixeyed/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354572560
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@dmcgowan
Copy link
Collaborator

That update button doesn't work correctly, need to rebase locally and push up

sixeyed added 2 commits May 17, 2017 22:04
Signed-off-by: Elton Stoneman <elton@sixeyed.com>
Signed-off-by: Elton Stoneman <elton@sixeyed.com>
@sixeyed
Copy link
Contributor Author

sixeyed commented May 17, 2017

By now we're on Alpine 1.8, so just the ARG lines added.

@stevvooe
Copy link
Collaborator

@sixeyed Could you fix these to remove the merge commits?

@sixeyed
Copy link
Contributor Author

sixeyed commented May 23, 2017

My fork is badly diverged... Closing this and will open a new PR with a clean merge history.

@sixeyed sixeyed closed this May 23, 2017
@dmcgowan dmcgowan removed this from the Registry/2.7 milestone Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants