-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARGs for cross compiling #2209
Conversation
Signed-off-by: Elton Stoneman <elton@sixeyed.com>
Codecov Report
@@ Coverage Diff @@
## master #2209 +/- ##
==========================================
- Coverage 61.57% 51.5% -10.08%
==========================================
Files 125 125
Lines 11397 11397
==========================================
- Hits 7018 5870 -1148
- Misses 3493 4781 +1288
+ Partials 886 746 -140
Continue to review full report at Codecov.
|
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM golang:1.7-alpine | |||
FROM golang:1.8-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we are quite on 1.8 yet.
Thanks for the fix! We aren't quite on 1.8 yet, so if you could leave the Dockerfile on 1.7, we can get this merged. |
Please sign your commits following these rules: $ git clone -b "master" git@github.com:sixeyed/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354572560
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
That update button doesn't work correctly, need to rebase locally and push up |
Signed-off-by: Elton Stoneman <elton@sixeyed.com>
Signed-off-by: Elton Stoneman <elton@sixeyed.com>
By now we're on Alpine |
@sixeyed Could you fix these to remove the merge commits? |
My fork is badly diverged... Closing this and will open a new PR with a clean merge history. |
Bump Go to 1.8 and add build args. Defaults to Linux/x64 but can build for other platforms - e.g.