Avoid use of __file__

[jayvdb]

It appears the use of __file__ here is mostly unnecessary, and can easily be replaced with importlib.resources/pkgutil. See indygreg/PyOxidizer#69 for more info about why, but the tl;dr version is __file__ is an optional attribute and should not be relied upon.

Loading of resources from the runtime package should ideally be done using importlib.resources and backport importlib_resources, however pkgutil could be used to avoid the need for the backport. Using pkgutil doesn't work under PyOxidizer 0.4, however I expect that will be fixed soon.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jayvdb]

This is still valid:

The first two are runtime use of __file__.

git grep __file__
compose/cli/utils.py:    filename = os.path.join(os.path.dirname(compose.__file__), 'GITSHA')
compose/config/validation.py:    return os.path.dirname(os.path.abspath(__file__))
script/release/const.py:REPO_ROOT = os.path.join(os.path.dirname(__file__), '..', '..')
setup.py:    path = os.path.join(os.path.dirname(__file__), *parts)

[stale]

This issue has been automatically marked as not stale anymore due to the recent activity.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it had not recent activity during the stale period.

[jayvdb]

ping @ndeloof , can you re-open

[thaJeztah]

Let me reopen.

Looks like you have a fair understanding of what changes need to be made; were you considering opening a pull request with those changes?

[stale]

This issue has been automatically marked as not stale anymore due to the recent activity.

[stale]

This issue has been automatically marked as not stale anymore due to the recent activity.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jayvdb]

Still a problem

git grep __file__
compose/cli/utils.py:    filename = os.path.join(os.path.dirname(compose.__file__), 'GITSHA')
compose/config/validation.py:    return os.path.dirname(os.path.abspath(__file__))
script/release/const.py:REPO_ROOT = os.path.join(os.path.dirname(__file__), '..', '..')
setup.py:    path = os.path.join(os.path.dirname(__file__), *parts)

However PyOxidizer now supports pkgutil, so that is now an easy and backwards compatible way to solve these

https://github.com/indygreg/PyOxidizer/blob/f5aecad5bf5123e5910a9ebb552815c6fa524edd/pyembed/docs/oxidized_importer_behavior_and_compliance.rst#pkgutil-compatibility

[stale]

This issue has been automatically marked as not stale anymore due to the recent activity.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jayvdb]

Issue now redundant.