-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify
command
#6408
Comments
Thanks for the suggestion @trajano ! The way I look at it, this seems like a very specific scenario you want to introduce as a mainline command. I'd assume users would have wildly differing expectations of what a Note that the |
NP we already have the "tests" for the Java apps using testcontainers. However, for something simple I'd rather avoid all the harness that is needed. But I'd rather see if there's any interest on this from other members before we just close it much like json-schema-org/json-schema-spec#396 generated a lot of interest. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it had not recent activity during the stale period. |
Is your feature request related to a problem? Please describe.
For CI, it would be good to verify that the docker-compose would work correctly.
Describe the solution you'd like
When I do
docker-compose verify
it does the same thing asdocker-compose up
and waits for thehealthcheck
to pass for all the services. Once it passes, it runsdocker-compose down
to tear down the app.Some other parameters to consider are:
--build
force a build even if it is not needed--limit=60s
time limit before giving up on health checks to pass--keep-up
keeps the services up after verifying. This allows more complex integration tests to be executed after the healthchecks are up.Describe alternatives you've considered
We create a separate test application that waits for the stack to come up and run our tests.
The text was updated successfully, but these errors were encountered: